[PATCH] D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 21:12:40 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:2367
 
-    uint64_t IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
+    uint64_t IdxVal = N->getConstantOperandVal(1);
 
----------------
Not sure that I like that we repeated the "1" here when we already have `Idx`. It's potentially more code too since we need to dereference N again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131642/new/

https://reviews.llvm.org/D131642



More information about the llvm-commits mailing list