[PATCH] D130516: [llvm] compression classes

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D130516#3710972 <https://reviews.llvm.org/D130516#3710972>, @MaskRay wrote:

> I have only taken very brief look at the new version. Having an enum class `CompressionKind` with a parallel `CompressionAlgorithm` seems redundant.
> `friend CompressionAlgorithm *CompressionKind::operator->() const;` looks magical.
>
> I hope that someone insisting on object-oriented design can put up a version with less boilerplate to compete with D130506 <https://reviews.llvm.org/D130506>.

Posted something more comparable to D130506 <https://reviews.llvm.org/D130506> in D131638 <https://reviews.llvm.org/D131638> - hard to compare, though - D130506 <https://reviews.llvm.org/D130506> is additive, whereas D131638 <https://reviews.llvm.org/D131638> and this D130516 <https://reviews.llvm.org/D130516> are more replacements - though a different with my change there is at least for the initial patch leaving the old APIs in place, with the intent to incrementally change the usages until the old API can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130516/new/

https://reviews.llvm.org/D130516