[PATCH] D130881: [SelectionDAG] Properly copy ExtraInfo on RAUW
Marco Elver via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 10 15:14:42 PDT 2022
melver marked an inline comment as done.
melver added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:11819
+void SelectionDAG::copyExtraInfo(SDNode *From, SDNode *To) {
+ assert(From && To);
+ auto I = SDEI.find(From);
----------------
vitalybuka wrote:
> this assert is inconsistent with the rest of the code
It's similar to the one in transferDbgValues(). Only that copyExtraInfo already takes the unwrapped pointers as it makes usage a bit easier where we don't have the source SDValue. I'd like to keep it to prevent easily avoidable mistakes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130881/new/
https://reviews.llvm.org/D130881
More information about the llvm-commits
mailing list