[PATCH] D131624: [lld-macho] Ensure cached objects are affected by `-object_path_lto`

Leonard Grey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 14:56:24 PDT 2022


lgrey created this revision.
lgrey added a project: lld-macho.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: lld-macho.
Herald added a project: All.
lgrey requested review of this revision.
Herald added a project: LLVM.

This refactors LTO compile to look more like COFF, where cache hits and misses are all funneled through the same code path.

Previously, cache hits were *not* being saved to `-object_path_lto`, which led to them sometimes falling out of the cache before `dsymutil` could process them. As a side effect of the refactor, cached objects are now saved with `-save-temps` as well, which seems desirable.

(Deleted `lld/test/MachO/lto-cache-dsymutil.ll` and rolled it into `lld/test/MachO/lto-object-path.ll`, since the cache-only, non object path approach is unreliable anyway).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131624

Files:
  lld/MachO/LTO.cpp
  lld/test/MachO/lto-cache-dsymutil.ll
  lld/test/MachO/lto-object-path.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131624.451638.patch
Type: text/x-patch
Size: 5551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220810/9e45ae63/attachment.bin>


More information about the llvm-commits mailing list