[PATCH] D131290: [llvm-objdump] Create name for fake sections
Namhyung Kim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 10 14:56:20 PDT 2022
namhyung marked an inline comment as done.
namhyung added inline comments.
================
Comment at: llvm/include/llvm/Object/ELF.h:784
for (auto Phdr : *PhdrsOrErr) {
- if (!(Phdr.p_type & ELF::PT_LOAD) || !(Phdr.p_flags & ELF::PF_X))
+ if ((Phdr.p_type != ELF::PT_LOAD) || !(Phdr.p_flags & ELF::PF_X)) {
+ ++Idx;
----------------
I've found a bug in this code - it should check equality.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131290/new/
https://reviews.llvm.org/D131290
More information about the llvm-commits
mailing list