[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Thanks for the reviews! FWIW, as this is a rather notable change, I'd add this to the release notes along with the patch:

  +Changes to the Windows Target
  +-----------------------------
  +
  +* For MinGW, generate embedded ``-exclude-symbols:`` directives for symbols
  +  with hidden visibility, omitting them from automatic export of all symbols.
  +  This roughly makes hidden visibility work like it does for other object
  +  file formats.
  +

What do you think, @rnk @MaskRay @mati865, should we try to backport this set to 15.x already, or is it too disruptive? I think msys2 might end up backporting it to their distribution in any case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121