[PATCH] D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

In D131522#3713909 <https://reviews.llvm.org/D131522#3713909>, @thakis wrote:

> Thanks!
>
> I wonder if ml allows nested procs to refer to the parameters of the outer proc – then we'd have to handle activation records like gcc creates them for its nested functions.
>
> But we don't even implement parameters for proc at all, so that's moot for now :)

"Good" news - if you provide arguments to PROC that would require prologue/epilogue support (even if prologues and epilogues are disabled), nesting is suddenly disallowed. This is true if the arguments are provided to the inner PROC, the outer PROC, or both. So this will never come up... when we add parameter support, we'll just need to block nesting when parameters are provided.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131522/new/

https://reviews.llvm.org/D131522