[PATCH] D112256: [FPEnv][EarlyCSE] Add support for CSE of constrained FP intrinsics, take 2

Wed Aug 10 11:51:45 PDT 2022

spatel added a comment.

In D112256#3702602 <https://reviews.llvm.org/D112256#3702602>, @kpn wrote:

> Address review comments.
>
> I'm leaving support for strict exception behavior out because it would make the patch more complicated and I'm really not sure the change would be worth it. Since we can't eliminate any traps with ebStrict we can't really CSE. So the added complication would only benefit this propagation of constant true and false. And said complication wouldn't have anything to do with the "maytrap" case that this ticket is for anyway.

My previous comments might've been unclear: I'm not asking for a functional change, I'm just wondering why there is no test for `strict` in the true/false test file. Shouldn't it be there for completeness independently of this patch?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112256/new/

https://reviews.llvm.org/D112256