[PATCH] D131608: [IR] Change access rights of PredIterator members

Dmitry Vassiliev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 11:38:28 PDT 2022


slydiman created this revision.
slydiman added reviewers: sunfish, RKSimon, hamzasood.
slydiman added a project: LLVM.
Herald added a project: All.
slydiman requested review of this revision.
Herald added a subscriber: llvm-commits.

These members were made private here https://github.com/llvm/llvm-project/commit/6177386b05ddaaee04160b153a41ed4edbd7bcaf without an explanation.
Our customers have an own implementation inherited from PredIterator with updated advancePastNonTerminators().
The access specifier `protected` looks resonable and safe here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131608

Files:
  llvm/include/llvm/IR/CFG.h


Index: llvm/include/llvm/IR/CFG.h
===================================================================
--- llvm/include/llvm/IR/CFG.h
+++ llvm/include/llvm/IR/CFG.h
@@ -47,7 +47,7 @@
   using pointer = Ptr *;
   using reference = Ptr *;
 
-private:
+protected:
   using Self = PredIterator<Ptr, USE_iterator>;
   USE_iterator It;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131608.451581.patch
Type: text/x-patch
Size: 331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220810/44002666/attachment.bin>


More information about the llvm-commits mailing list