[PATCH] D131330: [llvm][Demangle] Add getter for FunctionEncoding::Attrs

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 11:24:43 PDT 2022


ldionne added a comment.

In D131330#3706912 <https://reviews.llvm.org/D131330#3706912>, @Michael137 wrote:

> @urnathan @ldionne any idea who is responsible for mirroring this change in libcxxabi?

It's actually the other way around! According to `libcxxabi/src/demangle/README.txt`, the change should be done in `libcxxabi/src/demangle` and then `libcxxabi/src/demangle/cp-to-llvm.sh` can be used to mirror. Note that changing `libcxxabi` will also have the effect of triggering libc++abi's CI pipeline, which in turn should have at least some coverage for the demangler changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131330/new/

https://reviews.llvm.org/D131330



More information about the llvm-commits mailing list