[PATCH] D131577: [MemorySanitizer] Support memcpy.inline and memset.inline

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/include/llvm/IR/InstVisitor.h:210-214
+  RetTy visitMemSetInlineInst(MemSetInlineInst &I){ DELEGATE(MemIntrinsic); }
   RetTy visitMemCpyInst(MemCpyInst &I)            { DELEGATE(MemTransferInst); }
   RetTy visitMemCpyInlineInst(MemCpyInlineInst &I) {
     DELEGATE(MemTransferInst);
   }
----------------
I believe this should be like this



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2573
+  /// instrumentation should be disabled with the no_sanitize attribute.
+  void visitMemCpyInlineInst(MemCpyInlineInst &I) {
+    visitMemCpyInst(I);
----------------
we don't need this if it's properly fowarded to MemCpyInst


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131577/new/

https://reviews.llvm.org/D131577