[PATCH] D131595: [MC] Avoid calling vector<FieldInfo> members before FieldInfo is defined

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 10:09:15 PDT 2022


ilya-biryukov created this revision.
ilya-biryukov added a reviewer: alexfh.
Herald added a subscriber: hiraditya.
Herald added a project: All.
ilya-biryukov requested review of this revision.
Herald added a project: LLVM.

The C++ Standard requires a complete type T when using any members of
`vector<T>`, see
https://eel.is/c++draft/vector#overview-4.

This only breaks with latest libc++ in C++20 mode and does not show up
in the common configurations.
We have an internal experimental configuration that discovered this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131595

Files:
  llvm/lib/MC/MCParser/MasmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131595.451537.patch
Type: text/x-patch
Size: 8937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220810/a810c39e/attachment.bin>


More information about the llvm-commits mailing list