[PATCH] D131220: [NFC][MLGO] ML Regalloc Priority Advisor

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 09:27:33 PDT 2022


MatzeB added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.h:1
+//===- RegAllocPriorityAdvisor.h - Interference resolution ------*- C++ -*-===//
+//
----------------
This comment seems off/wrong.


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.h:6-16
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/Pass.h"
+
+namespace llvm {
+
----------------
We really should have some comments here, either on the file header or the classes to have at least some sentences explaining what this is doing / used for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131220/new/

https://reviews.llvm.org/D131220



More information about the llvm-commits mailing list