[PATCH] D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:333
+                .Default(-1);
+        if (Characteristic == -1) {
+          return Error(KeywordLoc,
----------------
My bot remarks:

```
../../llvm/lib/MC/MCParser/COFFMasmParser.cpp(333,28): warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare]
        if (Characteristic == -1) {
            ~~~~~~~~~~~~~~ ^  ~~
```

Either use `static_cast<unsigned>(-1)` or `UINT_MAX`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131523/new/

https://reviews.llvm.org/D131523