[PATCH] D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 10 08:37:49 PDT 2022
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:322
+ return false;
+ } else {
+ return TokError("OPTION PROLOGUE is currently unsupported");
----------------
nit: no else after return
================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:325
+ }
+ } else if (Option.equals_insensitive("epilogue")) {
+ StringRef MacroId;
----------------
nit: no else after return
================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:333
+ return false;
+ } else {
+ return TokError("OPTION EPILOGUE is currently unsupported");
----------------
nit: no else after return
================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:336
+ }
+ } else {
+ return TokError("OPTION '" + Option + "' is currently unsupported");
----------------
nit: no else after return
================
Comment at: llvm/test/tools/llvm-ml/option_prologue_epilogue_none.asm:3
+
+OPTION PROLOGUE:NONE, EPILOGUE:NONE
+
----------------
nit: maybe `pRoLoGuE:nOnE` and `EPILogue:None` to test case insensitivity too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131524/new/
https://reviews.llvm.org/D131524
More information about the llvm-commits
mailing list