[PATCH] D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Ship it :)



================
Comment at: llvm/lib/MC/MCParser/COFFMasmParser.cpp:349
+                         .CaseLower("const", SectionKind::getReadOnly())
+                         .Default(SectionKind::getData());
+  if (Kind.isText()) {
----------------
epastor wrote:
> thakis wrote:
> > Should we warn on unknown classes?
> Strangely, I don't think so - my testing suggests that ML64.EXE treats any unknown class as equivalent to DATA.
Ah cool, even covered by tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131523/new/

https://reviews.llvm.org/D131523