[PATCH] D131254: [AMDGPU][GISel] Enable Selection of ADD3 for G_PTR_ADD

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh planned changes to this revision.
Pierre-vh added a comment.

- Need to fix the GISelPredicateCode thing. I need to understand why the Cxx predicate is emitted before the feature check with those changes.
- Need to reevaluate the whole `AllowPointerOperands` approach, it feels awfully hacky but I'm not sure of what's the alternative.
- The whole impl in `addTypeCheckPredicate` also feels hacky so I should take another look at it and check if it can be simplified.
- Need to determine if `G_PTR_ADD (G_ADD)` folding is something desirable? It happens now because the parent and child pattern both have 2 opcodes possibles. We could enforce them to match somehow (maybe by adding another predicate of sorts).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131254/new/

https://reviews.llvm.org/D131254