[PATCH] D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V

[Alexey Baturo via Phabricator via llvm-commits]

smd added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_setjmp_riscv64.S:77
+  // no rv64if or lp64f
+#if (__riscv_flen == 32) || defined(__riscv_float_abi_single)
+# error "Unsupported case"
----------------
jrtc27 wrote:
> FLEN is irrelevant, only the floating-point ABI matters. This also doesn't fail for lp64q. What you want is:
> 
> * __riscv_float_abi_soft - do nothing
> * __riscv_float_abi_double - save/restore
> * anything else - error
Makes sense, fixed. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131341/new/

https://reviews.llvm.org/D131341