[PATCH] D131492: [RISCV] Implement isMaskAndCmp0FoldingBeneficial hook

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 07:22:05 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

Please update the submission comment and code comment to emphasize the sink *and duplicate* part.  Sinking to me is strictly code motion, not duplication.  The restriction on andi only makes sense when you consider the duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131492/new/

https://reviews.llvm.org/D131492



More information about the llvm-commits mailing list