[PATCH] D131564: [AMDGPU][MC][GFX11][NFC] Correct tests for 16-bit VOP2 opcodes which use v128 or higher VGPRs

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 06:37:40 PDT 2022


dp created this revision.
dp added reviewers: Joe_Nash, foad.
Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

It looks like other `VOP1/VOP2/VOPC` tests are fine and need no corrections.


https://reviews.llvm.org/D131564

Files:
  llvm/test/MC/AMDGPU/gfx11_asm_vop2.s


Index: llvm/test/MC/AMDGPU/gfx11_asm_vop2.s
===================================================================
--- llvm/test/MC/AMDGPU/gfx11_asm_vop2.s
+++ llvm/test/MC/AMDGPU/gfx11_asm_vop2.s
@@ -37,11 +37,11 @@
 v_fmaak_f16 v5, v1, v2, 0x1121
 // GFX11: encoding: [0x01,0x05,0x0a,0x70,0x21,0x11,0x00,0x00]
 
-v_fmaak_f16 v255, v1, v2, 0x1121
-// GFX11: encoding: [0x01,0x05,0xfe,0x71,0x21,0x11,0x00,0x00]
+v_fmaak_f16 v127, v1, v2, 0x1121
+// GFX11: encoding: [0x01,0x05,0xfe,0x70,0x21,0x11,0x00,0x00]
 
-v_fmaak_f16 v5, v255, v2, 0x1121
-// GFX11: encoding: [0xff,0x05,0x0a,0x70,0x21,0x11,0x00,0x00]
+v_fmaak_f16 v5, v127, v2, 0x1121
+// GFX11: encoding: [0x7f,0x05,0x0a,0x70,0x21,0x11,0x00,0x00]
 
 v_fmaak_f16 v5, 0, v2, 0x1121
 // GFX11: encoding: [0x80,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
@@ -55,8 +55,8 @@
 v_fmaak_f16 v5, -4.0, v2, 0x1121
 // GFX11: encoding: [0xf7,0x04,0x0a,0x70,0x21,0x11,0x00,0x00]
 
-v_fmaak_f16 v5, v1, v255, 0x1121
-// GFX11: encoding: [0x01,0xff,0x0b,0x70,0x21,0x11,0x00,0x00]
+v_fmaak_f16 v5, v1, v127, 0x1121
+// GFX11: encoding: [0x01,0xff,0x0a,0x70,0x21,0x11,0x00,0x00]
 
 v_fmaak_f16 v5, v1, v2, 0xa1b1
 // GFX11: encoding: [0x01,0x05,0x0a,0x70,0xb1,0xa1,0x00,0x00]
@@ -103,11 +103,11 @@
 v_fmamk_f16 v5, v1, 0x1121, v3
 // GFX11: encoding: [0x01,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00]
 
-v_fmamk_f16 v255, v1, 0x1121, v3
-// GFX11: encoding: [0x01,0x07,0xfe,0x6f,0x21,0x11,0x00,0x00]
+v_fmamk_f16 v127, v1, 0x1121, v3
+// GFX11: encoding: [0x01,0x07,0xfe,0x6e,0x21,0x11,0x00,0x00]
 
-v_fmamk_f16 v5, v255, 0x1121, v3
-// GFX11: encoding: [0xff,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00]
+v_fmamk_f16 v5, v127, 0x1121, v3
+// GFX11: encoding: [0x7f,0x07,0x0a,0x6e,0x21,0x11,0x00,0x00]
 
 v_fmamk_f16 v5, 0, 0x1121, v3
 // GFX11: encoding: [0x80,0x06,0x0a,0x6e,0x21,0x11,0x00,0x00]
@@ -124,8 +124,8 @@
 v_fmamk_f16 v5, v1, 0xa1b1, v3
 // GFX11: encoding: [0x01,0x07,0x0a,0x6e,0xb1,0xa1,0x00,0x00]
 
-v_fmamk_f16 v5, v1, 0x1121, v255
-// GFX11: encoding: [0x01,0xff,0x0b,0x6e,0x21,0x11,0x00,0x00]
+v_fmamk_f16 v5, v1, 0x1121, v127
+// GFX11: encoding: [0x01,0xff,0x0a,0x6e,0x21,0x11,0x00,0x00]
 
 v_pk_fmac_f16 v5, v1, v2
 // GFX11: encoding: [0x01,0x05,0x0a,0x78]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131564.451437.patch
Type: text/x-patch
Size: 2192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220810/a2cf2620/attachment.bin>


More information about the llvm-commits mailing list