[PATCH] D131504: [ARM][AArch64] Dont use macros for half instrinsics in NeonEmitter

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 00:50:28 PDT 2022


dmgreen added a comment.

Yeah I don't really understand it either. But this code seems to always add -fallow-half-arguments-and-returns from the driver:
https://github.com/llvm/llvm-project/blob/5331e1229aa6d0d33b5ec9fab7c05310187746d9/clang/lib/Driver/ToolChains/Clang.cpp#L1787
And it is present in the flags for both of these compiles:
https://godbolt.org/z/fG64nYrT8
So I believe for Arm and AArch64 it should always be present through clang. The "additions" in this patch are really just adding the option to -cc1 test lines where it should always have been present.

This patch is just a cleanup. It's almost an NFC, except that the arm_neon.h and arm_fp.h change slightly - some functions that were macros are now proper functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131504/new/

https://reviews.llvm.org/D131504



More information about the llvm-commits mailing list