[PATCH] D131387: [WebAssembly] Produce error when encountering unlowerable Wasm global accesses

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 23:32:01 PDT 2022


pmatos accepted this revision.
pmatos added a comment.
This revision is now accepted and ready to land.

LGTM

Indeed the tests for these are not comprehensive and these bugs haven't been found before as this sort of code hasn't been used in anger. I think the error message is fine for now but once the clang work is finished, we should refactor and improve this code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131387/new/

https://reviews.llvm.org/D131387



More information about the llvm-commits mailing list