[compiler-rt] 5990cf3 - Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is available""
Med Ismail Bennani via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 21:45:41 PDT 2022
Author: Med Ismail Bennani
Date: 2022-08-09T21:45:21-07:00
New Revision: 5990cf380644704ef5b41ef8e32c561d5f64baf7
URL: https://github.com/llvm/llvm-project/commit/5990cf380644704ef5b41ef8e32c561d5f64baf7
DIFF: https://github.com/llvm/llvm-project/commit/5990cf380644704ef5b41ef8e32c561d5f64baf7.diff
LOG: Revert "Reland "[compiler-rt][BF16] Provide __truncsfbf2 only when __bf16 is available""
This reverts commit ab4e5ed441d475ead43bc4ce1cdef842688292f4 since it
causes a build failure on macOS:
https://green.lab.llvm.org/green/job/lldb-cmake/45984/
Added:
Modified:
compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
compiler-rt/cmake/builtin-config-ix.cmake
compiler-rt/lib/builtins/CMakeLists.txt
compiler-rt/lib/builtins/fp_trunc.h
compiler-rt/lib/builtins/truncdfbf2.c
compiler-rt/lib/builtins/truncsfbf2.c
Removed:
################################################################################
diff --git a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
index 9ece3c2c38559..2c9983c6a1ae3 100644
--- a/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
+++ b/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
@@ -406,8 +406,6 @@ macro(darwin_add_builtin_libraries)
append_list_if(COMPILER_RT_HAS_ASM_LSE -DHAS_ASM_LSE CFLAGS)
- append_list_if(COMPILER_RT_HAS_BFLOAT16 -DCOMPILER_RT_HAS_BFLOAT16 CFLAGS)
-
set(PROFILE_SOURCES ../profile/InstrProfiling.c
../profile/InstrProfilingBuffer.c
../profile/InstrProfilingPlatformDarwin.c
diff --git a/compiler-rt/cmake/builtin-config-ix.cmake b/compiler-rt/cmake/builtin-config-ix.cmake
index 62e8281b919cf..5aa2114fab93f 100644
--- a/compiler-rt/cmake/builtin-config-ix.cmake
+++ b/compiler-rt/cmake/builtin-config-ix.cmake
@@ -30,14 +30,6 @@ _Float16 foo(_Float16 x) {
"
)
-builtin_check_c_compiler_source(COMPILER_RT_HAS_BFLOAT16
-"
-__bf16 foo(__bf16 x) {
- return x;
-}
-"
-)
-
builtin_check_c_compiler_source(COMPILER_RT_HAS_ASM_LSE
"
asm(\".arch armv8-a+lse\");
diff --git a/compiler-rt/lib/builtins/CMakeLists.txt b/compiler-rt/lib/builtins/CMakeLists.txt
index 05c37930dae83..6143457cc9339 100644
--- a/compiler-rt/lib/builtins/CMakeLists.txt
+++ b/compiler-rt/lib/builtins/CMakeLists.txt
@@ -699,8 +699,6 @@ else ()
append_list_if(COMPILER_RT_HAS_FLOAT16 -DCOMPILER_RT_HAS_FLOAT16 BUILTIN_CFLAGS)
- append_list_if(COMPILER_RT_HAS_BFLOAT16 -DCOMPILER_RT_HAS_BFLOAT16 BUILTIN_CFLAGS)
-
append_list_if(COMPILER_RT_HAS_STD_C11_FLAG -std=c11 BUILTIN_CFLAGS)
# These flags would normally be added to CMAKE_C_FLAGS by the llvm
diff --git a/compiler-rt/lib/builtins/fp_trunc.h b/compiler-rt/lib/builtins/fp_trunc.h
index 91f614528ab3f..7a54564a3520a 100644
--- a/compiler-rt/lib/builtins/fp_trunc.h
+++ b/compiler-rt/lib/builtins/fp_trunc.h
@@ -60,7 +60,7 @@ typedef uint16_t dst_rep_t;
static const int dstSigBits = 10;
#elif defined DST_BFLOAT
-typedef __bf16 dst_t;
+typedef uint16_t dst_t;
typedef uint16_t dst_rep_t;
#define DST_REP_C UINT16_C
static const int dstSigBits = 7;
diff --git a/compiler-rt/lib/builtins/truncdfbf2.c b/compiler-rt/lib/builtins/truncdfbf2.c
index b87385eeaca05..dbd54dcd50caf 100644
--- a/compiler-rt/lib/builtins/truncdfbf2.c
+++ b/compiler-rt/lib/builtins/truncdfbf2.c
@@ -6,11 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#if defined(COMPILER_RT_HAS_BFLOAT16)
#define SRC_DOUBLE
#define DST_BFLOAT
#include "fp_trunc_impl.inc"
COMPILER_RT_ABI dst_t __truncdfbf2(double a) { return __truncXfYf2__(a); }
-
-#endif
diff --git a/compiler-rt/lib/builtins/truncsfbf2.c b/compiler-rt/lib/builtins/truncsfbf2.c
index 42ddab32a2f1c..6bed116af9868 100644
--- a/compiler-rt/lib/builtins/truncsfbf2.c
+++ b/compiler-rt/lib/builtins/truncsfbf2.c
@@ -6,11 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#if defined(COMPILER_RT_HAS_BFLOAT16)
#define SRC_SINGLE
#define DST_BFLOAT
#include "fp_trunc_impl.inc"
COMPILER_RT_ABI dst_t __truncsfbf2(float a) { return __truncXfYf2__(a); }
-
-#endif
More information about the llvm-commits
mailing list