[PATCH] D131540: [test][NFC] Strengthen an assertion for LLVM checkouts at interesting paths

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 20:37:17 PDT 2022


xen0n created this revision.
Herald added a project: All.
xen0n requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously only the "store" string was being checked for not appearing
twice, but unfortunately the check also looked at the ModuleID and
source_filename lines, so the test case would fail if the LLVM
checkout's absolute path contained the substring "store".

Fix this spurious test failure by checking against "store i8" instead,
which presumably should not appear in any reasonable path.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131540

Files:
  llvm/test/Transforms/GVNHoist/non-trivial-phi.ll


Index: llvm/test/Transforms/GVNHoist/non-trivial-phi.ll
===================================================================
--- llvm/test/Transforms/GVNHoist/non-trivial-phi.ll
+++ llvm/test/Transforms/GVNHoist/non-trivial-phi.ll
@@ -1,7 +1,7 @@
 ; RUN: opt -gvn-hoist %s -S -o - | FileCheck %s
 
-; CHECK: store
-; CHECK-NOT: store
+; CHECK: store i8
+; CHECK-NOT: store i8
 
 target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131540.451344.patch
Type: text/x-patch
Size: 450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220810/a6f52c16/attachment.bin>


More information about the llvm-commits mailing list