[PATCH] D131473: [XCOFF] ignore the cold attribute.

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 19:35:47 PDT 2022


Esme marked an inline comment as done.
Esme added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:40
   switch (Attribute) {
+  case MCSA_Cold:
+    return false;
----------------
DiggerLin wrote:
>  prefer to add comment here . 
> MCXCOFFStreamer will be called when generate the xcoff object file. 
> so "AIX XCOFF doesn't support the cold feature" instead of  AIX "assembly doesn't support the cold feature." ?
Addressed. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131473/new/

https://reviews.llvm.org/D131473



More information about the llvm-commits mailing list