[PATCH] D131427: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI

[Pengxuan Zheng via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9bb66224239e: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI (authored by pzheng).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131427/new/

https://reviews.llvm.org/D131427

Files:
  llvm/lib/Target/ARM/ARMISelLowering.cpp
  llvm/test/CodeGen/ARM/stack-guard-rwpi.ll


Index: llvm/test/CodeGen/ARM/stack-guard-rwpi.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/ARM/stack-guard-rwpi.ll
@@ -0,0 +1,28 @@
+; RUN: llc -mtriple=arm-- --relocation-model=rwpi %s -o - | \
+; RUN: FileCheck %s --check-prefixes=RWPI
+; RUN: llc -mtriple=arm-- --relocation-model=ropi %s -o - | \
+; RUN: FileCheck %s --check-prefixes=ROPI
+; RUN: llc -mtriple=arm-- --relocation-model=pic %s -o - | \
+; RUN: FileCheck %s --check-prefixes=PIC
+
+; RWPI:        ldr     {{r[0-9]+}}, .LCPI0_0
+; RWPI:        .LCPI0_0:
+; RWPI-NEXT:           .long   __stack_chk_guard(sbrel)
+
+; ROPI:        ldr     {{r[0-9]+}}, .LCPI0_0
+; ROPI:        .LCPI0_0:
+; ROPI-NEXT:           .long   __stack_chk_guard
+
+; PIC:         ldr     {{r[0-9]+}}, .LCPI0_0
+; PIC:         .LCPI0_0:
+; PIC-NEXT:    .Ltmp0:
+; PIC-NEXT:            .long   __stack_chk_guard(GOT_PREL)-((.LPC0_0+8)-.Ltmp0)
+
+define dso_local i32 @foo(i32 %t) nounwind sspstrong {
+entry:
+  %vla = alloca i32, i32 %t
+  %call = call i32 @baz(i32* %vla)
+  ret i32 %call
+}
+
+declare dso_local i32 @baz(i32*)
Index: llvm/lib/Target/ARM/ARMISelLowering.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -21106,7 +21106,10 @@
   return InsertFencesForAtomic;
 }
 
-bool ARMTargetLowering::useLoadStackGuardNode() const { return true; }
+bool ARMTargetLowering::useLoadStackGuardNode() const {
+  // ROPI/RWPI are not supported currently.
+  return !Subtarget->isROPI() && !Subtarget->isRWPI();
+}
 
 void ARMTargetLowering::insertSSPDeclarations(Module &M) const {
   if (!Subtarget->getTargetTriple().isWindowsMSVCEnvironment())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131427.451281.patch
Type: text/x-patch
Size: 1763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220809/85385573/attachment.bin>