[llvm] 9bb6622 - [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI

[Pengxuan Zheng via llvm-commits]

Author: Pengxuan Zheng
Date: 2022-08-09T14:59:08-07:00
New Revision: 9bb66224239eb2bd4f91e40b9a56da24a8dd533d

URL: https://github.com/llvm/llvm-project/commit/9bb66224239eb2bd4f91e40b9a56da24a8dd533d
DIFF: https://github.com/llvm/llvm-project/commit/9bb66224239eb2bd4f91e40b9a56da24a8dd533d.diff

LOG: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI

ROPI/RWPI are not supported with LOAD_STACK_GUARD currently.

Reviewed By: nickdesaulniers, rengolin

Differential Revision: https://reviews.llvm.org/D131427

Added: 
    llvm/test/CodeGen/ARM/stack-guard-rwpi.ll

Modified: 
    llvm/lib/Target/ARM/ARMISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cpp
index b6b6da5f5f87..361dbc835cee 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -21106,7 +21106,10 @@ bool ARMTargetLowering::shouldInsertFencesForAtomic(
   return InsertFencesForAtomic;
 }
 
-bool ARMTargetLowering::useLoadStackGuardNode() const { return true; }
+bool ARMTargetLowering::useLoadStackGuardNode() const {
+  // ROPI/RWPI are not supported currently.
+  return !Subtarget->isROPI() && !Subtarget->isRWPI();
+}
 
 void ARMTargetLowering::insertSSPDeclarations(Module &M) const {
   if (!Subtarget->getTargetTriple().isWindowsMSVCEnvironment())

diff  --git a/llvm/test/CodeGen/ARM/stack-guard-rwpi.ll b/llvm/test/CodeGen/ARM/stack-guard-rwpi.ll
new file mode 100644
index 000000000000..c7eeee39dca5
--- /dev/null
+++ b/llvm/test/CodeGen/ARM/stack-guard-rwpi.ll
@@ -0,0 +1,28 @@
+; RUN: llc -mtriple=arm-- --relocation-model=rwpi %s -o - | \
+; RUN: FileCheck %s --check-prefixes=RWPI
+; RUN: llc -mtriple=arm-- --relocation-model=ropi %s -o - | \
+; RUN: FileCheck %s --check-prefixes=ROPI
+; RUN: llc -mtriple=arm-- --relocation-model=pic %s -o - | \
+; RUN: FileCheck %s --check-prefixes=PIC
+
+; RWPI:        ldr     {{r[0-9]+}}, .LCPI0_0
+; RWPI:        .LCPI0_0:
+; RWPI-NEXT:           .long   __stack_chk_guard(sbrel)
+
+; ROPI:        ldr     {{r[0-9]+}}, .LCPI0_0
+; ROPI:        .LCPI0_0:
+; ROPI-NEXT:           .long   __stack_chk_guard
+
+; PIC:         ldr     {{r[0-9]+}}, .LCPI0_0
+; PIC:         .LCPI0_0:
+; PIC-NEXT:    .Ltmp0:
+; PIC-NEXT:            .long   __stack_chk_guard(GOT_PREL)-((.LPC0_0+8)-.Ltmp0)
+
+define dso_local i32 @foo(i32 %t) nounwind sspstrong {
+entry:
+  %vla = alloca i32, i32 %t
+  %call = call i32 @baz(i32* %vla)
+  ret i32 %call
+}
+
+declare dso_local i32 @baz(i32*)