[PATCH] D130944: [llvm-profdata] Support JSON as as an output-only format

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 14:06:46 PDT 2022


davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:87
+      JOS.attributeArray("body", [&] {
+        for (const auto &I : BodySamples) {
+          const LineLocation &Loc = I.first;
----------------
too many nesting levels. Perhaps split out the lamda?


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:115
+      JOS.attributeArray("callsites", [&] {
+        for (const auto &I : CallsiteSamples)
+          for (const auto &FS : I.second) {
----------------
split out the lamda?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130944/new/

https://reviews.llvm.org/D130944



More information about the llvm-commits mailing list