[PATCH] D131521: [SDAG] avoid generating libcall in function with nobuiltin

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 13:46:36 PDT 2022


spatel created this revision.
spatel added reviewers: efriedma, andrewrk, nickdesaulniers, RKSimon.
Herald added subscribers: hiraditya, mcrosier.
Herald added a project: All.
spatel requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a potentially better alternative to D131452 <https://reviews.llvm.org/D131452> that also appears to avoid the infinite loop bug from:
https://github.com/llvm/llvm-project/issues/56403

This is again a minimal fix to minimize merging pain for the release. But if this makes sense, then we'd want to guard all of the RTLIB generation (and other libcalls?) with 'nobuiltin'?


https://reviews.llvm.org/D131521

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/test/CodeGen/AArch64/umulo-128-legalisation-lowering.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131521.451260.patch
Type: text/x-patch
Size: 4117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220809/0d89da83/attachment.bin>


More information about the llvm-commits mailing list