[PATCH] D131452: [InstCombine] avoid generating mul intrinsic that lowers as a libcall

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I wonder if we should have some more comprehensive solution to the whole "recursive call" thing, as opposed to the ad-hoc transform avoidance we currently use... but this seems fine for now.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:4066
+  // function call if the target can't handle the type. We allow the transform
+  // for vectors under the assumption that those will always be expanded inline.
+  Type *Ty = X->getType();
----------------
The comment here should more specifically call out the possibility of a recursive call.  If we have a non-legal divide, we're probably generating a libcall anyway...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131452/new/

https://reviews.llvm.org/D131452