[PATCH] D131503: [DAGCombine] Combine signext_inreg of extract-extend

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 08:54:26 PDT 2022


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13168
+    SDValue SignExtExtendee =
+        DAG.getNode(ISD::SIGN_EXTEND, SDLoc(N), InnerExtVT, Extendee);
+
----------------
(style) Create this node inside the if() below - otherwise you end up with dead nodes that could possibly affect later transforms


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131503/new/

https://reviews.llvm.org/D131503



More information about the llvm-commits mailing list