[PATCH] D130832: [X86][BF16] Make backend type bf16 to follow the psABI

Tue Aug 9 08:49:38 PDT 2022

pengfei added inline comments.

================
Comment at: llvm/test/CodeGen/X86/bfloat.ll:97
+; CHECK-NEXT:    addss {{[-0-9]+}}(%r{{[sb]}}p), %xmm0 # 4-byte Folded Reload
+; CHECK-NEXT:    cvtss2sd %xmm0, %xmm0
+; CHECK-NEXT:    addq $24, %rsp
----------------
pengfei wrote:
> LuoYuanke wrote:
> > The `%add` is not converted to `bfloat` from float and it is converted to `double` directly. Is this the expected behaviour?
> Good catch! I believe it is a bug, but it's not related to this patch. I'll do a follow up.
Did an experiment on D131502. But I don't want to rush it for 15.0 release given the problem has been existing on many targets using `TypePromoteFloat`, https://godbolt.org/z/cqooE1zT3

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130832/new/

https://reviews.llvm.org/D130832