[PATCH] D131149: [RISCV] Add cost model for fp-mask cast op.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 08:31:48 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/required change before landing



================
Comment at: llvm/test/Analysis/CostModel/RISCV/cast.ll:118
 ; RISCV64-LABEL: 'fpext'
-; RISCV64-NEXT:  Cost Model: Found an estimated cost of 1 for instruction:   %v0 = fpext <8 x half> undef to <8 x float>
-; RISCV64-NEXT:  Cost Model: Found an estimated cost of 2 for instruction:   %v1 = fpext <8 x half> undef to <8 x double>
-; RISCV64-NEXT:  Cost Model: Found an estimated cost of 1 for instruction:   %v2 = fpext <8 x float> undef to <8 x double>
-; RISCV64-NEXT:  Cost Model: Found an estimated cost of 1 for instruction:   ret void
+; RISCV64-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %v0 = fpext <8 x half> undef to <8 x float>
+; RISCV64-NEXT:  Cost Model: Found an estimated cost of 2 for instruction: %v1 = fpext <8 x half> undef to <8 x double>
----------------
You have a bunch of white space changes here which make the test diffs impossible to read.

Please update the test diffs once on a clean checkout, commit the change, and then apply your change and regenerate the test diffs.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131149/new/

https://reviews.llvm.org/D131149



More information about the llvm-commits mailing list