[PATCH] D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.
Aman LaChapelle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 08:11:49 PDT 2022
bzcheeseman created this revision.
Herald added a project: All.
bzcheeseman requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D131500
Files:
llvm/docs/CodeReview.rst
Index: llvm/docs/CodeReview.rst
===================================================================
--- llvm/docs/CodeReview.rst
+++ llvm/docs/CodeReview.rst
@@ -147,6 +147,12 @@
you are fairly certain that a particular community member will wish to review,
even if that person hasn't done so yet.
+If you approve of the idea/concept of a patch but feel unqualified to approve,
+another option (other than accepting the patch) is to simply award a token
+(right-hand side in Phabricator) to indicate support without indicating to
+other reviewers that the patch has been accepted and reviewed in their
+dashboard.
+
Note that, if a reviewer has requested a particular community member to review,
and after a week that community member has yet to respond, feel free to ping
the patch (which literally means submitting a comment on the patch with the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131500.451161.patch
Type: text/x-patch
Size: 856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220809/0128ba10/attachment.bin>
More information about the llvm-commits
mailing list