[PATCH] D130689: [LLVM] Update C++ standard to 17

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 07:58:26 PDT 2022


thieta added a comment.

In D130689#3709742 <https://reviews.llvm.org/D130689#3709742>, @aaron.ballman wrote:

> One thing I think would be a definite improvement is to have done an RFC on Discourse for these changes so that downstreams have a chance to weigh in on the impact. The patch was put up on Jul 28 and landed about a week later without any notification to the rest of the community who might not be watching cfe-commits -- that's a very fast turnaround and very little notification for such a significant change.

Yeah this is on me. Honestly I didn't expect it to be that much of a problem but rather the toolchain requirement we posted as part of it would be the big hurdle where bot owners would have to upgrade to get the right versions. But lesson learned  and we should add some more delays in the policy here: https://llvm.org/docs/DeveloperPolicy.html#id23 and cover the C++ standards upgrade.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130689/new/

https://reviews.llvm.org/D130689



More information about the llvm-commits mailing list