[PATCH] D131189: [DAGCombine] Hoist shifts out of a logic operations tree.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/CodeGen/X86/shift-combine.ll:556
   %c.shifted = lshr i32 %c, 16
   %xor.ab = xor i32 %a.shifted, %b
   %xor.cd = xor i32 %c.shifted, %d
----------------
Can you vary the operand order in these tests to check the commuted patterns? It seems like we are only testing the case where the shifts are operand 0 of the logic ops.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131189/new/

https://reviews.llvm.org/D131189