[PATCH] D129636: Fix a LSR debug invariance issue

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 04:50:27 PDT 2022


chrisjackson accepted this revision.
chrisjackson added a comment.

I think this is s succinct solution and I don't perceive a problem with expsing the extra SCEV method, as I've done something similar myself in the past, as mentioned above. I would like to see a comment explaining the need to call forget(), otherwise lgtm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129636/new/

https://reviews.llvm.org/D129636



More information about the llvm-commits mailing list