[PATCH] D127964: [DCE] Eliminate no-op atan and atan2 calls

[Mohammed Nurul Hoque via Phabricator via llvm-commits]

mohammed-nurulhoque added a comment.

> There's an open question about what to do with denormals. We recently added denorm-attribute-aware folding with:
> D116952 <https://reviews.llvm.org/D116952>
> D128647 <https://reviews.llvm.org/D128647>
> ...and we mentioned that it is a work-in-progress to get consistent behavior for intrinsics and libcalls. Exclude denorm inputs in this patch?

The denormal question will affect the exact constant that will be substituted for the call, but it doesn't affect whether atan/atan2 is free from side-effects, no?
This patch only changes whether atan/atan2 is safe to remove, it doesn't change how we substitute constants.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127964/new/

https://reviews.llvm.org/D127964