[PATCH] D129958: [IndVars] Eliminate redundant type cast with different sizes

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/IndVarSimplify/floating-point-small-iv.ll:181
+
+define void @sitofp_fptoui_range_zext_postinc() {
+;
----------------
Allen wrote:
> nikic wrote:
> > This isn't quite what I had in mind. By "postinc IV" I mean that `%inc.int` gets passed to sitofp, rather than `%iv.int`. I think your current code may result in a wrong insertion point for this case.
> Now, I just update code to fix the crash for the case with "postinc IV", and I'll try to improve it next patch as I need some time to get the right insertion point.
Shouldn't the insertion point simply be `CI`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129958/new/

https://reviews.llvm.org/D129958