[PATCH] D131427: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/stack-guard-rwpi.ll:1
+; RUN: llc -mtriple=arm-- --relocation-model=rwpi %s -o - | FileCheck %s
+
----------------
Perhaps add a second RUN line with another relocation model showing that you do see the stack guard?

Maybe even a third, for ROPI, just to make sure neither of them are removed by accident in the future.


================
Comment at: llvm/test/CodeGen/ARM/stack-guard-rwpi.ll:5
+;CHECK:        .LCPI0_0:
+;CHECK-NEXT:           .long   __stack_chk_guard(sbrel)
+define dso_local i32 @foo(i32 %t) nounwind sspstrong {
----------------
I'm not fully aware how the stack guard works in practice, is this an example of it not lowered?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131427/new/

https://reviews.llvm.org/D131427