[PATCH] D131467: [LoongArch] Define the new-style reloc types

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 00:55:42 PDT 2022


jhenderson added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/LoongArch.def:64-65
+
+// And finally, the new-style relocs whose processing do not require a stack
+// machine.
+//
----------------
The "And finally" risks more relocs being added in the future, thus meaning this set is no longer the final set, and the comment going stale. Similarly, in 10+ years time, "new-style" may not sound particularly right. I'd probably just go simply with "Relocs whose processing do not require a stack machine."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131467/new/

https://reviews.llvm.org/D131467



More information about the llvm-commits mailing list