[PATCH] D131439: [ELF] Support --package-metadata

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 14:18:43 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/test/ELF/package-metadata.s:1
+// REQUIRES: x86
+
----------------
`#`


================
Comment at: lld/test/ELF/package-metadata.s:3
+
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+
----------------



================
Comment at: lld/test/ELF/package-metadata.s:5
+
+// RUN: ld.lld %t.o -o %t --package-metadata="{}"
+// RUN: llvm-readelf -n %t | FileCheck %s --check-prefixes=NOTE,FIRST
----------------
Prefer single quotes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131439/new/

https://reviews.llvm.org/D131439



More information about the llvm-commits mailing list