[PATCH] D131392: [ARM] Emit local aliases (.Lfoo$local) for functions

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 13:26:24 PDT 2022


arichardson created this revision.
Herald added subscribers: jeroen.dobbelaere, hiraditya, kristof.beyls.
Herald added a project: All.
arichardson added a reviewer: MaskRay.
Herald added a subscriber: StephenFan.
arichardson published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ARMAsmPrinter::emitFunctionEntryLabel() was not calling the base class
function so the $local alias was not being emitted. This should not have
any function effect right now since ARM does not generate different code
for the $local symbols, but it could be improved in the future.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131392

Files:
  llvm/lib/Target/ARM/ARMAsmPrinter.cpp


Index: llvm/lib/Target/ARM/ARMAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMAsmPrinter.cpp
+++ llvm/lib/Target/ARM/ARMAsmPrinter.cpp
@@ -82,8 +82,7 @@
     OutStreamer->emitSymbolAttribute(S, MCSA_ELF_TypeFunction);
     OutStreamer->emitLabel(S);
   }
-
-  OutStreamer->emitLabel(CurrentFnSym);
+  AsmPrinter::emitFunctionEntryLabel();
 }
 
 void ARMAsmPrinter::emitXXStructor(const DataLayout &DL, const Constant *CV) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131392.450775.patch
Type: text/x-patch
Size: 486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220808/7ecfc65f/attachment.bin>


More information about the llvm-commits mailing list