[PATCH] D130483: [RISCV] Add CodeGen support of RISCV Zca Extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

There's a check for FeatureStdExtC in RISCVMatInt.cpp does that need to be updated?



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCObjectFileInfo.cpp:24
+          STI->hasFeature(RISCV::FeatureExtZca))
+             ? 2
+             : 4;
----------------
Did this come from clang-format?


================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:171
   bool hasStdExtZca() const { return HasStdExtZca; }
+  bool hasStdExtCOrZca() const { return HasStdExtC | HasStdExtZca; }
   bool hasStdExtZfhmin() const { return HasStdExtZfhmin; }
----------------
`||`


================
Comment at: llvm/test/MC/RISCV/rv32zca-aliases-valid.s:1
+# RUN: llvm-mc -triple=riscv32 -mattr=+experimental-zca -riscv-no-aliases < %s \
+# RUN:     | FileCheck -check-prefixes=CHECK-EXPAND,CHECK-INST %s
----------------
Can we add these command lines to rv32c-aliases-valid instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130483/new/

https://reviews.llvm.org/D130483