[PATCH] D130141: [RISCV] Add MC support of RISCV Zca Extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:114
     {"zvfh", RISCVExtensionVersion{0, 1}},
+    {"zca", RISCVExtensionVersion{0, 70}},
 };
----------------
Can we alphabetize this?


================
Comment at: llvm/test/MC/RISCV/rv32zca-invalid.s:1
+# RUN: not llvm-mc -triple=riscv32 -mattr=+experimental-zca -mattr=+no-rvc-hints < %s 2>&1 \
+# RUN:     | FileCheck %s
----------------
Can this command line be added to `rv32c-invalid.s`? Test content appears to be the same


================
Comment at: llvm/test/MC/RISCV/rv32zca-valid.s:1
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+experimental-zca -riscv-no-aliases -show-encoding \
+# RUN:     | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s
----------------
Can this be merged with rv32c-valid.s?


================
Comment at: llvm/test/MC/RISCV/rv64zca-valid.s:19
+# CHECK-ASM: encoding: [0x82,0x60]
+# CHECK-NO-EXT:  error: instruction requires the following: 'C' (Compressed Instructions)
+# CHECK-NO-RV64:  error: instruction requires the following: RV64I Base Instruction Set
----------------
Should these error mesages mention Zca?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130141/new/

https://reviews.llvm.org/D130141