[PATCH] D131220: [NFC][MLGO] ML Regalloc Priority Advisor

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

Add a patch description: what is this patch trying to achieve?



================
Comment at: llvm/lib/CodeGen/MLRegallocPriorityAdvisor.cpp:1
+#include "AllocationOrder.h"
+#include "RegAllocGreedy.h"
----------------
This should come in a different patch.


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.cpp:95
+}
\ No newline at end of file

----------------
new line


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.h:25
+
+class RegAllocPriorityAdvisorAnalysis : public ImmutablePass {
+public:
----------------
I'd prefer this were introduced in a subsequent change. This current change can stay focused at factoring out the prioritization logic behind the RegAllocPriorityAdvisor interface.


================
Comment at: llvm/lib/CodeGen/RegAllocPriorityAdvisor.h:68
+} // namespace llvm
\ No newline at end of file

----------------
add a new line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131220/new/

https://reviews.llvm.org/D131220