[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 11:46:55 PDT 2022


barannikov88 added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:916
+  /// Tests if the target is {arm,thumb}-none-none-{eabi,eabihf}.
+  bool isARMBareMetal() const {
+    if (getArch() != Triple::arm && getArch() != Triple::thumb)
----------------
Any future change to these methods will force recompilation of the whole project. It is better to move the definitions into the corresponding cpp file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131225/new/

https://reviews.llvm.org/D131225



More information about the llvm-commits mailing list