[PATCH] D131376: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 09:29:40 PDT 2022


sbc100 added inline comments.


================
Comment at: lld/wasm/Driver.cpp:379
+       args.getAllArgValues(OPT_export_memory_with_name)) {
+    config->memoryExports.insert(name);
+  }
----------------
Why allow the same memory to be exported multiple times under different names?

I guess it could be useful but I'd like to see it done in a more standard way that could be re-used for all symbols types (and looking forward to multiple memories).

We have support for symbols alias in the assembly format and object format so I would hope would achieve multiple names that way if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131376/new/

https://reviews.llvm.org/D131376



More information about the llvm-commits mailing list