[PATCH] D131181: [AMDGPU] Fix si-annotate-control-flow for visited else branch

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added a comment.

In D131181#3706014 <https://reviews.llvm.org/D131181#3706014>, @ruiling wrote:

>> I doubt that would help.
>
> You can have a try to remove isUniformlyReached() check for UnreachableBlock (i.e. remove the line https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp#L214) to see what would happen.

Removing isUniformlyReached() fixes the issue. Thanks. However, I got a few regressions:

  LLVM :: CodeGen/AMDGPU/GlobalISel/bool-legalization.ll
  LLVM :: CodeGen/AMDGPU/si-annotate-control-flow-condition-common-blocks.ll
  LLVM :: CodeGen/AMDGPU/skip-if-dead.ll
  LLVM :: CodeGen/AMDGPU/switch-default-block-unreachable.ll

I am checking whether these are real issues or need an update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131181/new/

https://reviews.llvm.org/D131181