[PATCH] D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

Is the main goal of the patch enabling a runtime-determined set of features, to avoid the overhead of allocating buffers for unused features? If yes, I'd just scope it at that change: making the feature storage a vector, and simplifying `TrainingInputFeatures` as such.

Then I'd just add the change you have in mind, i.e. skip having a 'dummy feature'.



================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:207
+#define DEVELOPMENT_RA_EVICT_FEATURES_LIST(M)                                  \
+  M(int64_t, dummy_feature, PerLiveRangeShape,                                 \
+    "A dummy variable for testing the release/development feature split")
----------------
I don't understand how this is used: if the issue is figuring out if we are doing release or development, we can just check the type of the advisor or of the evaluator?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131209/new/

https://reviews.llvm.org/D131209